2024-09-04  Simon Josefsson  <simon@josefsson.org>

	version 2.5.90
	* NEWS: Record release date.

2024-09-03  Simon Josefsson  <simon@josefsson.org>

	Update gnulib revision.
	* bootstrap.conf (GNULIB_REVISION): Update.

2024-09-03  Collin Funk  <collin.funk1@gmail.com>

	maint: Use stat-time from Gnulib.
	* bootstrap.conf (gnulib_modules): Add stat-time.
	* configure.ac: Prefer Gnulib checks for struct stat.
	* libls/cmp.c (off_cmp): New function.
	(modcmp, acccmp, statcmp, sizecmp): Use functions from stat-time.
	* src/rcp.c (write_stat_time): Likewise.

2024-08-31  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	NEWS: mention telnet integer overflow handling fix
	* NEWS: Mention the recent fix for signed integer overflow
	handling.

2024-08-25  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: check for regression of overflow fix
	Commit a6d9848a32fafa763548e54b44cb094abdac915d fixed an
	integer overflow when parsing a numerical value given to
	the send do, send dont, send will, and send wont commands.
	Check that overly large or small values are caught and
	reported as 'bad value' even if they cannot be stored in
	a 64-bit integer.

	* tests/telnet-localhost.sh: New check to detect regressions
	in the recent integer overflow fix.

2024-08-25  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: avoid spurious output from telnet tests
	Avoid spurious output when manually running telnet-localhost.sh.
	Standard output is already suppressed for the respective tests,
	but suppressing output to standard error was overlooked.

	* tests/telnet-localhost.sh: Redirect uninteresting error output
	from parser regression tests to /dev/null.

2024-08-24  Collin Funk  <collin.funk1@gmail.com>

	telnet: Handle integer overflow gracefully.
	* bootstrap.conf (gnulib_modules): Add inttypes and xstrtoimax.
	* telnet/commands.c (send_tncmd): Don't allow the integer argument to
	'send dont' to overflow.

2024-08-03  Collin Funk  <collin.funk1@gmail.com>

	ftp: Cleanup port number to string conversion.
	* bootstrap.conf (gnulib_modules): Add intprops.
	* ftp/ftp.c: Include intprops.h.
	(portstr): Size buffer to fit exactly 'in_port_t' and a NUL byte.
	(hookup): Use 'in_port_t' to represent the port instead of int. Use
	sprintf since the buffer size is safe.
	* ftp/extern.h (hookup): Adjust deceleration.
	* ftp/ftp_var.h: Include netinet/in.h for type definitions.

2024-07-28  Collin Funk  <collin.funk1@gmail.com>

	rcp: Don't call va_start without calling va_end.
	* src/rcp.c (run_err): Move va_start call after the early return.

2024-07-18  Simon Josefsson  <simon@josefsson.org>

	Cleanup susp/ayt definitions, inspired by NetBSD.
	sys_bsd.c:680:12: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype]
	      void ayt ();
	           ^
	sys_bsd.c:1003:1: note: conflicting prototype is here
	ayt (int sig MAYBE_UNUSED)
	^

	Fix MacOSX build error, adopting NetBSD's "solution" to cast the function.
	sys_bsd.c:734:24: error: incompatible function pointer types passing 'void (void)' to parameter of type 'void (*)(int)' [-Wincompatible-function-pointer-types]
	      signal (SIGINFO, ayt_status);
	                       ^~~~~~~~~~

2024-07-18  Flavio Cruz  <flaviocruz@gmail.com>

	Hurd: use mach_msg_type_number_t for file_get_fs_options since its size is not the same as size_t for x86_64. (tiny patch)
	This fixes an incompatible-pointer-types error on GCC14.

2024-07-09  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: allow unprivileged ping to localhost
	Some operating systems, e.g., GNU/Linux (with appropriate
	configuration) and macOS, support unprivileged ICMP echo
	operation.  Since commit 05a2f938e3f56ce0136966136410c5f9e20c37a7
	from 2016-02-12, this is supported for the IPv4 ping program.
	But the test for basic ping functionality still requires to be
	run with an effective user id of root and is skipped otherwise.
	Change this to test IPv4 ping operation without root privileges
	if supported.

	The IPv6 version of ping, 'ping6', does not (yet) allow use
	without root privileges, thus skip the IPv6 part of the test
	unless having root privileges.

	* tests/ping-localhost.sh: Do not skip the test for IPv4 if
	run without root privileges unless they are required.

2024-06-30  Collin Funk  <collin.funk1@gmail.com>

	ping, ping6: Fix mistake in previous change.
	* ping/ping.c (ping_run): Set the timespec to zero if it is negative
	before calling pselect.
	* ping/ping6.c (ping_run): Likewise.

2024-06-28  Collin Funk  <collin.funk1@gmail.com>

	doc: Fix typos.
	* README: Fix spelling of similarly.
	* doc/inetutils.texi (ifconfig invocation): Fox spelling of or.
	(logger invocation): Fix spelling of influential.
	(Ftp commands): Fix spelling of intended.
	(Configuration file): Fix spelling of limited.
	(telnetd invocation): Fix spelling of construct.
	(tftpd invocation): Fix spelling of suppress. Use "in spite of"
	instead of "inspite".

	ftp: Modernize time functions.
	* ftp/Makefile.am (LDADD): Add $(CLOCK_TIME_LIB).
	* ftp/extern.h (struct timespec): Add a forward declaration.
	(ptransfer): Use timespec instead of timeval.
	(tvsub): Remove declaration.
	* ftp/ftp.c: Include <float.h> and <timespec.h>
	(sendrequest): Use current_timespec instead of gettimeofday.
	(recvrequest): Likewise.
	(ptransfer): Use timespec_sub instead of tvsub. Divide by FLT_MIN
	instead of 1 if seconds is zero.
	(tvsub): Remove function.

2024-06-27  Collin Funk  <collin.funk1@gmail.com>

	ping, ping6: Modernize time functions.
	* bootstrap.conf (gnulib_modules): Add timespec-add.
	* ping/Makefile.am (LDADD): Add $(CLOCK_TIME_LIB),
	$(PTHREAD_SIGMASK_LIB), and $(SELECT_LIB).
	* ping/libping.c (ping_init): Use current_timespec instead of
	gettimeofday.
	* ping/ping_common.c (tvsub): Remove function.
	(ping_timeout_p): Return a bool. Use timespec_sub and
	current_timespec.
	* ping/ping_common.h (PING_SET_INTERVAL): Expect a timespec instead of
	a timeval.
	(struct ping_data): Store the start time in a timespec instead of a
	timeval.
	(tvsub): Remove declaration.
	(ping_timeout_p): Adjust prototype.
	* ping/ping.c (send_echo): Use current_timespec.
	(ping_init): Likewise.
	(ping_run): Likewise. Use pselect.
	* ping/ping6.c (send_echo): Use current_timespec.
	(print_echo): Likewise.
	(ping_init): Likewise.
	(ping_run): Likewise. Use pselect.
	* ping/ping_echo.c (print_echo): Use current_timespec.

	traceroute: Modernize time functions.
	* bootstrap.conf (gnulib_modules): Add gettime, pselect, timespec, and
	timespec-sub.
	* src/Makefile.am (traceroute_LDADD): Add $(CLOCK_TIME_LIB),
	$(PTHREAD_SIGMASK_LIB), and $(SELECT_LIB).
	* src/traceroute.c (trace_t): Use a timespec instead of timeval.
	(do_try): Use pselect instead of select. Use current_timespec instead
	of gettimeofday. Use timespec_sub.
	(trace_write): Use current_timespec instead of gettimeofday.

2024-05-12  Simon Josefsson  <simon@josefsson.org>

	NEWS: Mention reproducible tarballs.

	telnetd: Make --help output reproducible.
	* telnetd/telnetd.c (argp_options): Don't use PATH_LOGIN.

	maint: Make tarball reproducible.
	* cfg.mk (TAR_OPTIONS): Hard code mode and mtime.
	* Makefile.am (mtime-NEWS-to-git-HEAD): Add.
	(dist-hook): Use it.

2024-05-11  Collin Funk  <collin.funk1@gmail.com>

	telnet: Make function declarations C23 compatible.
	* NEWS: Mention C23 support.
	* telnet/commands.c (Sendlist, Togglelist, Setlist, ModeList, SlcList)
	(EnvList): Replace '0' pointers with NULL.
	(struct authlist, struct encryptlist): Add types to function
	prototypes.
	(AuthList, EncryptList): Cast some function pointers. Replace '0'
	pointers with NULL.
	(auth_cmd, encrypt_cmd): Fix number of arguments passed to functions.

2024-05-10  Collin Funk  <collin.funk1@gmail.com>

	libtelnet: Make encryption decls compatible with C23.
	* libtelnet/enc-proto.h (findencryption, finddecryption): Add
	prototypes.
	* libtelnet/encrypt.c (struct key_info): Add the parameter type.

	maint: Fix most instances of '-Wstrict-prototypes'.
	* libinetutils/des_rw.c (des_clear_key, des_read, des_write): Don't
	use K&R-style function declarations.
	* ifconfig/system/linux.c (pnd_read): Use void instead of an empty
	argument list.
	* libtelnet/auth.c (auth_status, auth_request, auth_send_retry):
	Likewise.
	* libtelnet/kerberos5.c (kerberos5_cleanup): Likewise.
	* ping/ping.c (ping_run): Likewise.
	* ping/ping6.c (ping_run): Likewise.
	* ping/ping6.h (ping_run): Likewise.
	* ping/ping_impl.h (ping_run): Likewise.
	* telnet/authenc.c (net_encrypt, telnet_spin): Likewise.
	* telnet/commands.c (_setlist_init, auth_help, EncryptHelp)
	(ayt_status): Likewise.
	* telnet/sys_bsd.c (TerminalNewMode): Likewise.
	* telnet/tn3270.c (outputPurge, Push3270, Finish3270, SetIn3270)
	(tn3270_ttype): Likewise.
	* telnetd/state.c (willoption): Likewise.
	* telnetd/telnetd.h (pty_buffer_level): Likewise.
	* telnetd/term.c (term_send_eof, term_change_eof, tty_linemode)
	(tty_isecho, tty_flowmode, tty_restartany, tty_israw)
	(tty_isbinaryin, tty_isbinaryout, tty_isediting, tty_istrapsig)
	(tty_issofttab, tty_islitecho, tty_iscrnl, copy_termbuf): Likewise.
	* telnetd/termstat.c (termstat, _termstat): Likewise.
	* telnetd/utility.c (net_encrypt, telnet_spin): Likewise.
	* src/rcp.c (krb_realmofhost): Add the parameter type.
	* telnet/ring.c (ring_encrypt): Likewise.
	* telnet/ring.h (ring_encrypt): Likewise.

2024-05-09  Collin Funk  <collin.funk1@gmail.com>

	maint: Remove uses of the 'register' keyword.
	* libicmp/*.c: Don't use the 'register' keyword when declaring
	variables or arguments.
	* libinetutils/*.c: Likewise.
	* libtelnet/*.h: Likewise.
	* libtelnet/*.c: Likewise.
	* src/*.c: Likewise.
	* talk/*.c: Likewise.
	* telnet/*.c: Likewise.
	* telnetd/*.c: Likewise.

	maint: Remove unnecessary standard library extern function decls.
	* ftp/cmds.c (account, user): Don't declare getpass since it is
	defined in unistd.h.
	* ftp/ftp.c (login): Likewise. Don't declare fclose and pclose since
	they are defined in stdio.h.
	* ftpd/extern.h: Don't declare getusershell since it is defined in
	unistd.h.
	* ftpd/ftpd.c: Don't declare fclose since it is defined in stdio.h.
	* libinetutils/logwtmp.c: Don't declare errno since it is defined in
	errno.h.
	* libtelnet/misc.c (auth_encrypt_user): Include string.h and don't
	declare strdup.
	* telnet/authenc.c (telnet_gets):  Don't declare getpass since it is
	defined in unistd.h.
	* telnet/commands.c (hostname): Use NULL instead of 0.
	(env_init, shell): Include string.h and don't redeclare functions.

2024-05-08  Simon Josefsson  <simon@josefsson.org>

	maint: Add bootstrap* to EXTRA_DIST.
	Suggested by Guillem Jover.

2024-05-07  Collin Funk  <collin.funk1@gmail.com>

	maint: Update NEWS and run 'make indent'.
	* NEWS: Mention the AddressSanitizer error fixed by the previous
	commit.
	* ifconfig/printif.c (print_interfaceX): Run 'make indent' to satisfy
	syntax-check.

	ifconfig: Fix ASAN 'dynamic-stack-buffer-overflow' in formatting.
	* ifconfig/printif.c (print_interfaceX): Allocate the argv array on
	the heap as the format string is being processed. The previous
	'alloca' leads to invalid writes detected by ASAN and Valgrind when
	using the --format and --short options.

2024-05-06  Collin Funk  <collin.funk1@gmail.com>

	Fix sc_bsd_caddr checks.
	* libinetutils/if_index.c (if_nameindex): Don't cast non-void pointer
	arithmetic.
	* ftp/ftp.c (hookup): Don't cast pointers to memmove and memset.
	* src/inetd.c (getconfigent): Likewise.
	* telnet/commands.c (tn): Likewise.

	cfg.mk: Add checks for 'caddr_t'.
	* cfg.mk (sc_bsd_caddr): New rule to check for use of the 'caddr_t'
	type. This is an old BSD type representing a 'void *' or similar.

2024-05-06  Simon Josefsson  <simon@josefsson.org>

	maint: Run ./bootstrap --bootstrap-sync.

	cfg.mk: Remove upstreamed syntax checks.

	maint: Use GNULIB_REVISION instead of git submodule.

2024-05-04  Collin Funk  <collin.funk1@gmail.com>

	Fix sc_unsigned_int checks.
	* ftpd/ftpd.c (send_data, receive_data): Convert 'u_int' to
	'unsigned int'.
	* libinetutils/ttymsg.c (inetutils_ttymsg): Likewise.
	* libls/extern.h: Likewise.
	* libls/print.c (minor, printtype): Likewise.
	* libls/stat_flags.c (flags_to_string, string_to_flags): Likewise.
	* src/rlogin.c (winsize, get_window_size, getescape): Likewise.
	* src/rsh.c (copyargs): Likewise.

	cfg.mk: Add checks for 'u_int'.
	* cfg.mk (sc_unsigned_int): New rule.
	(sc_unsigned_short): Correct type in error message.

2024-05-02  Collin Funk  <collin.funk1@gmail.com>

	maint: Remove redundant 'environ' declarations.
	* src/rexecd.c: Remove 'extern char **environ' and instead rely on the
	gnulib declaration in unistd.h.
	* src/rshd.c: Likewise.
	* src/uucpd.c: Likewise.
	* telnet/commands.c: Likewise.
	* telnetd/pty.c: Likewise.
	* tests/addrpeek.c: Likewise.

2024-05-02  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	maint: fix "make syntax-check"
	The changes to ifconfig/options.c from the last commit broke the "indent"
	part of "make syntax-check".  Fix this.

	* ifconfig/options.c (parse_opt): Adjust indentation, no functional
	changes.

2024-04-24  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	ifconfig: prefix length handling fixes for -A
	With option -A, ifconfig accepted too small and too large prefix
	length values.  It also accepted non-numeric values starting with
	a number.  Depending on the given prefix length value, this could
	result in undefined behavior.  Using a valid prefix length of 0
	also resulted in undefined behavior and a wrong result on at least
	the x86_64 architecture.

	* NEWS: Mention ifconfig fixes.
	* ifconfig/options.c (parse_opt): Reject non-numeric prefix length
	values.  Reject too small and too large prefix length values for
	IPv4 addresses.  Avoid undefined behavior with a prefix length of 0.
	* tests/ifconfig.sh: Test rejection of invalid prefix length value
	examples.

2024-04-24  Simon Josefsson  <simon@josefsson.org>

	telnetd/telnetd.h: Don't include config.h in a header file.
	Reported by Collin Funk in
	https://lists.gnu.org/archive/html/bug-gnulib/2024-04/msg00398.html

	Drop HAVE_CONFIG_H.

2024-03-22  Simon Josefsson  <simon@josefsson.org>

	maint: Update gnulib submodule.

2024-03-22  Collin Funk  <collin.funk1@gmail.com>

	maint: Allow gnulib's readutmp module to use systemd. (tiny patch)

2024-01-01  Simon Josefsson  <simon@josefsson.org>

	maint: Run 'make update-copyright'.

	Re-enable copyright-check to catch old copyright years.

	maint: Update gnulib submodule.

2023-12-30  Simon Josefsson  <simon@josefsson.org>

	syslogd: Build fixes for macOS.
	Thanks to Rui Chen and Caleb Xu, see
	<https://savannah.gnu.org/bugs/?65093>.

2023-12-29  Simon Josefsson  <simon@josefsson.org>

	maint: post-release administrivia
	* NEWS: Add header line for next release.
	* .prev-version: Record previous version.
	* cfg.mk (old_NEWS_hash): Auto-update.

	version 2.5
	* NEWS: Record release date.

	doc: Add NEWS entry.

	maint: Re-indent using GNU indent 2.2.13.

	doc: Refer to COPYING in README as per policies (sc_readme_link_copying).

	maint: Sync bootstrap scripts.

	maint: Update gnulib submodule.

2023-07-31  Simon Josefsson  <simon@josefsson.org>

	Remove dummy README-hacking and README-prereq files.

	doc: Add NEWS entry for set*id() fixes.

	Indent changes in previous commit.

2023-07-31  Jeffrey Bencteux  <jeffbencteux@gmail.com>

	ftpd,rcp,rlogin,rsh,rshd,uucpd: fix: check set*id() return values
	Several setuid(), setgid(), seteuid() and setguid() return values
	were not checked in ftpd/rcp/rlogin/rsh/rshd/uucpd code potentially
	leading to potential security issues.

2023-07-31  Simon Josefsson  <simon@josefsson.org>

	Run ./boostrap --bootstrap-sync.  Drop autogen.sh and autopull.sh.

2023-07-22  Simon Josefsson  <simon@josefsson.org>

	Ignore syntax-check problem in unpatched README-release.

	cfg.mk: Sort sc's.  Disable public-submodule-commit.

	Update gnulib files.

2023-01-09  Simon Josefsson  <simon@josefsson.org>

	Indent code to fix 'make syntax-check'.

2023-01-09  Enrik Berkhan  <Enrik.Berkhan@inka.de>  (tiny change)

	ping: decode unreachable codes added in RFC 4443
	RFC 4443 added two new codes for ICMPv6 destination unreachable messages
	(type 1):

	5 - Source address failed ingress/egress policy
	6 - Reject route to destination

	Before:

	$ sudo ./ping/ping6 2a03:4000:54:b9a::5
	PING 2a03:4000:54:b9a::5 (2a03:4000:54:b9a::5): 56 data bytes
	64 bytes from 2a03:4000:54:b9a::5: Destination unreachable: Unknown code 6
	64 bytes from 2a03:4000:54:b9a::5: Destination unreachable: Unknown code 6
	64 bytes from 2a03:4000:54:b9a::5: Destination unreachable: Unknown code 6
	^C--- 2a03:4000:54:b9a::5 ping statistics ---
	3 packets transmitted, 0 packets received, 100% packet loss

	After:

	$ sudo ./ping/ping6 2a03:4000:54:b9a::5
	PING 2a03:4000:54:b9a::5 (2a03:4000:54:b9a::5): 56 data bytes
	64 bytes from 2a03:4000:54:b9a::5: Destination unreachable: Reject route to destination
	64 bytes from 2a03:4000:54:b9a::5: Destination unreachable: Reject route to destination
	64 bytes from 2a03:4000:54:b9a::5: Destination unreachable: Reject route to destination
	^C--- 2a03:4000:54:b9a::5 ping statistics ---
	3 packets transmitted, 0 packets received, 100% packet loss

2023-01-01  Simon Josefsson  <simon@josefsson.org>

	maint: Run 'make update-copyright'.

2022-10-26  Simon Josefsson  <simon@josefsson.org>

	Indent code.

2022-10-25  Simon Josefsson  <simon@josefsson.org>

	Update gnulib submodule.

	Ignore files generated by 'make web-manual-update'.

	maint: post-release administrivia
	* NEWS: Add header line for next release.
	* .prev-version: Record previous version.
	* cfg.mk (old_NEWS_hash): Auto-update.

	version 2.4
	* NEWS: Record release date.

	doc: Add NEWS entries.

2022-10-25  Samuel Thibault  <samuel.thibault@gnu.org>

	ifconfig hurd: Notify pfinet of interfaces
	When the pfinet translator is configured without any initial interface,
	ifconfig has to explicitly tell it the interfaces to be configured.
	This needs to be done before any SIOC ioctl with that interface name,
	thus introducing a system_preconfigure that is called before any other
	configuration.

	* ifconfig/system.h (system_preconfigure): New prototype.
	* ifconfig/system/hurd.c: Include hurd.h, hurd/paths.h, hurd/fsys.h,
	argz.h.
	(check_driving): New function.
	(system_preconfigure): New function.
	* ifconfig/system/bsd.c (system_preconfigure): New functions.
	* ifconfig/system/generic.c (system_preconfigure): Likewise.
	* ifconfig/system/linux.c (system_preconfigure): Likewise.
	* ifconfig/system/qnx.c (system_preconfigure): Likewise.
	* ifconfig/system/solaris.c (system_preconfigure): Likewise.
	* ifconfig/changeif.c (configure_if): Call system_preconfigure before
	other "set" functions.

2022-10-25  Samuel Thibault  <samuel.thibault@gnu.org>

	ifconfig: Support prefix length.
	Prefix lengths are much more convenient, support them as an alternative
	to passing -m separately from -A.

	* ifconfig/options.c (parse_opt): Detect prefix length, and in such a
	case, call parse_opt_set_netmask.

2022-10-25  Simon Josefsson  <simon@josefsson.org>

	Update gnulib submodule.

	Build fixes for C23 compatibility.
	* src/inetd.c (signal_set_handler): Clarify sighandler_t type.
	* ifconfig/printif.c, ifconfig/system/bsd.c, ifconfig/system/generic.c,
	  ifconfig/system/hurd.c, ifconfig/system/linux.c, src/tftp.c,
	  telnet/commands.c: Reorder MAYBE_UNUSED.
	* libtelnet/genget.c (isprefix, genget): Use const char.
	  libtelnet/genget.c (Ambiguous): Use void.
	* telnet/commands.c, telnet/externs.h, telnet/network.c,
	  telnet/telnet.c, telnet/utilities.c: Clarify empty function types,
	  and update callers.

2022-10-14  Simon Josefsson  <simon@josefsson.org>

	Don't use variable names true/bool, fixing gnulib builds and syncs with BSD.
	* src/rlogind.c (rlogind_mainloop): Replace 'true' with 'on'.
	* telnetd/telnetd.c (telnetd_setup): Likewise.
	* ftp/cmds.c (onoff): Replace 'bool' with 'val'.

	Run ./bootstrap --bootstrap-sync.
	* bootstrap: Updated.
	* autogen.sh, autopull.sh, bootstrap-funclib.sh: New files.

	Update gnulib submodule.

2022-10-02  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	ftp: Avoid crash via infinite macro recursion
	This fixes the problem reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00005.html>.

	* NEWS: Mention fix.
	* doc/inetutils.texi (Ftp commands):  Mention macro nesting depth
	limit.
	* ftp/domacro.c:  New constant MAX_MACRO_NESTING_DEPTH.
	(domacro):  Limit macro nesting depth to MAX_MACRO_NESTING_DEPTH.
	* tests/ftp-parser.sh:  Test execution of nested macros.

2022-10-02  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: Check for infinite recursion ftp crash
	* tests/Makefile.am (EXTRA_DIST): Add new binary fuzzer found input.
	* tests/crash-ftp-msg2021-12_05.bin: New file.  Input found via
	fuzzer that crashes ftp via infinite macro recursion.  Reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00005.html>.
	* tests/ftp-regressions.sh: Add currently failing check for regression
	of upcoming fix for bug reported by AiDai.

2022-10-01  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	ftp: Avoid NULL pointer dereference with nmap
	This fixes the problem reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00004.html>.

	* NEWS: Mention fix.
	* ftp/cmds.c (setnmap): Accept both space and tab characters
	between command arguments.

2022-10-01  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: Check for ftp crashes with "nmap" command
	* tests/Makefile.am (EXTRA_DIST): Add new binary fuzzer found input.
	* tests/crash-ftp-msg2021-12_04.bin: New file.  Input found via
	fuzzer that crashes ftp via NULL pointer dereference.  Reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00004.html>.
	* tests/ftp-parser.sh: Add currently failing tests with a tab
	between arguments to the "nmap" command.
	* tests/ftp-regressions.sh: Add currently failing check for regression
	of upcoming fix for bug reported by AiDai.

	tests: ftp file name translation command parsing
	* tests/ftp-parser.sh: Test setting file name translation
	arguments.

2022-09-30  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: ftp file name mapping command parsing
	* tests/ftp-parser.sh: Test that the "nmap" and "ntrans"
	commands produce a single output line.  Test setting file
	name mapping patterns using one or two input lines.  Test
	this for the proxy connection, too.

2022-09-25  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	ftp: Avoid heap buffer overflow in macro execution
	This fixes the problem reported by ZFeiXQ in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00016.html>.

	* NEWS: Mention fix.
	* ftp/domacro.c (domacro): Check buffer size before copying
	into buffer.  Reallocate buffer of sufficient size if necessary.

2022-09-25  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: Check for ftp heap buffer overflow
	* tests/Makefile.am (EXTRA_DIST): Add new binary fuzzer found input.
	* tests/crash-ftp-msg2021-12_16.bin: New file.  Input found via
	fuzzer that crashes ftp via heap buffer overflow.  Reported by ZFeiXQ in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00016.html>.
	* tests/ftp-regressions.sh: Add currently failing check for regression
	of upcoming fix for bug reported by ZFeiXQ.

2022-09-25  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	ftp: Avoid integer overflow in macro execution
	This fixes the problem reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00003.html>.

	* NEWS: Mention fix.
	* ftp/domacro.c: Include limits.h.
	(domacro): Avoid signed integer overflow.  Avoid out-of-bounds
	buffer access.

2022-09-25  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: Check for ftp integer overflow crash bug
	* cfg.mk (exclude_file_name_regexp--sc_trailing_blank)
	(exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF): Change
	pattern to match both binary fuzzer found input files used in tests.
	* tests/Makefile.am (EXTRA_DIST): Add new binary fuzzer found input.
	* tests/crash-ftp-msg2021-12_03.bin: New file.  Input found via
	fuzzer that crashes ftp via signed integer overflow and resulting
	out-of-bounds array access.  Reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00003.html>.
	* tests/ftp-regressions.sh: New file.  Currently failing checks
	for regression of upcoming fix for bug reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00003.html>.

2022-09-25  Simon Josefsson  <simon@josefsson.org>

	Fix srcdir in tools.sh.in.
	* tests/tools.sh.in (srcdir): Set fallback srcdir.

	Fix 'make dist' and 'make syntax-check'.
	* tests/Makefile.am (EXTRA_DIST): Unconditionally distribute crash file.
	* tests/crash-tftp-msg2021-12_18.bin: Renamed.
	* cfg.mk (exclude_file_name_regexp--sc_trailing_blank)
	(exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF): Add crash file.
	* tests/tools.sh (srcdir): Set fallback srcdir.
	* tests/tftp-regressions.sh: Use new filename in srcdir.

2022-09-22  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	Texinfo: typo fix
	* doc/inetutils.texi (inetd configuration file): Fix typo in
	configuration directory name.

2022-09-17  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: read binary fuzzer input from a file
	Instead of recreating the binary input found to crash tftp
	with printf(1), save the input in a file and use input
	redirection in the test.

	* tests/Makefile.ami (EXTRA_DIST): Move setting of EXTRA_DIST
	before setting dist_check_SCRIPTS.  Add the tftp crash input
	file when the tftp client is enabled.
	* tests/crash-tftp-msg2021-12_18: New file.  The input formerly
	crashing tftp.
	* tests/tftp-regressions.sh: Replace use of printf with input
	redirection.

2022-09-11  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tftp: Ignore excess arguments
	When given too many arguments to a command at the tftp cli,
	the buffer used to hold the arguments would overflow.  This
	could result in a crash.

	The problem was reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00018.html>.

	This commit fixes the test failure in the previously added
	file "tests/tftp-regressions.sh".

	* NEWS: Mention fix.
	* src/tftp.c (makeargv): Do not overflow argument buffer.

2022-09-11  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	tests: Check for tftp crash bug
	* tests/Makefile.am (dist_check_SCRIPTS)
	* tests/tftp-regressions.sh: New file.  Currently failing
	check for regression of fix for bug reported by AiDai in:
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00018.html>

2022-09-08  Simon Josefsson  <simon@josefsson.org>

	Doc fix, adding CVE.

2022-09-07  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	telnet: fix typo in diagnostic message
	* telnet/commands.c (makeargv): Print the newline after the
	sentence terminating period, not before.

2022-09-06  Guillem Jover  <guillem@hadrons.org>

	telnet: Add checks for option reply parsing limits
	This fixes buffer overflows caused by for example:

	  telnet -l`perl -e 'print "A"x5000'` localhost

	Origin: FreeBSD, https://cgit.freebsd.org/src/commit/?id=14aab889f4e50072a6b914eb95ebbfa939539dad
	Fixes: CVE-2019-0053

2022-09-03  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	telnetd: Handle early IAC EC or IAC EL receipt
	Fix telnetd crash if the first two bytes of a new connection
	are 0xff 0xf7 (IAC EC) or 0xff 0xf8 (IAC EL).

	The problem was reported in:
	<https://pierrekim.github.io/blog/2022-08-24-2-byte-dos-freebsd-netbsd-telnetd-netkit-telnetd-inetutils-telnetd-kerberos-telnetd.html>.

	* NEWS: Mention fix.
	* telnetd/state.c (telrcv): Handle zero slctab[SLC_EC].sptr and
	zero slctab[SLC_EL].sptr.

2022-07-08  Simon Josefsson  <simon@josefsson.org>

	doc: Mention more dependencies.  Drop obsolete text.

	maint: post-release administrivia
	* NEWS: Add header line for next release.
	* .prev-version: Record previous version.
	* cfg.mk (old_NEWS_hash): Auto-update.

	version 2.3
	* NEWS: Record release date.

	doc: Fix NEWS entries.

2022-07-08  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	telnet: Fix TTYPE subnegotiation off-by-one error.
	Fix off-by-one error in Terminal-Type option subnegotiation if the TERM
	variable has exactly 44 bytes.  In this case the SE byte (end of
	subnegotiation parameters) was replaced by a NUL byte.  This concerns
	the CVE-2019-0053 fixes.  Reported by Erik Auerswald in
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00004.html>.

	* NEWS: Mention fix.
	* telnet/telnet.c (suboption): Adjust length check to account for NUL
	byte written by snprintf().

2022-07-08  Erik Auerswald  <auerswal@unix-ag.uni-kl.de>

	telnet: Abort subnegotiation of XDISPLOC on error.
	Subnegotiation of the X Display Location option needs to be
	aborted when it cannot be completed.

	* NEWS: Mention fix.
	* telnet/telnet.c (suboption): Call send_wont() to abort when
	DISPLAY value does not fit into temporary buffer.

2022-07-08  Simon Josefsson  <simon@josefsson.org>

	whois: Support .art.
	Suggested by Chris Reveles <chris@talis.eco> in
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-01/msg00001.html>.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	logger: Don't read out of bounds on empty strings.
	Reported by AiDai in:
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00015.html>

	* src/logger.c (send_to_syslog): Handle empty strings.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	telnet: Fix crash of "set ' ' foo" command.
	Reported by ZFeiXQ and tiny patch by Erik Auerswald in
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00010.html>.

	* telnet/commands.c (setcmd): Don't crash on empty option.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	Check for telnet crash bug.
	* tests/telnet-localhost.sh: Check regression of
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00010.html>
	bug reported by ZFeiXQ and debugged by Erik Auerswald.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	telnet: Fix crash of "unset ' '" command.
	Reported by AiDai and tiny patch by Erik Auerswald in
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00007.html>.

	* telnet/commands.c (unsetcmd): Don't crash on empty option.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	Check for telnet crash bug.
	* tests/telnet-localhost.sh: Check regression of
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00007.html>
	bug reported by AiDai and debugged by Erik Auerswald.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	telnet: Make 'help help' output help string.
	Tiny patch by Erik Auerswald in
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00009.html>.

	* telnet/commands.c (cmdtab2): Fix 'help' string.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	telnet: Fix crash on 'help help' command.
	Reported by AiDai in
	<https://lists.gnu.org/archive/html/bug-inetutils/2021-12/msg00009.html>
	and debugged and tiny patch by Erik Auerswald in
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00009.html>.

	* telnet/commands.c (help): Don't crash on empty c->help.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	Check for telnet crash bug.
	* tests/telnet-localhost.sh: Check regression of
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00009.html>
	bug reported by AiDai and debugged by Erik Auerswald.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	telnet: Fix crash on too many options to 'help' command.
	Tiny patch from Erik Auerswald <auerswal@unix-ag.uni-kl.de> in
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00014.html>.

	* telnet/commands.c (TELNET_MAX_ARGS): New symbol.
	(margv): Use it instead of hard-coded value.
	(makeargv): Check if we reach limit instead of crashing.

2022-07-07  Simon Josefsson  <simon@josefsson.org>

	Check for telnet crash bug.
	* tests/telnet-localhost.sh: Check regression of
	<https://lists.gnu.org/archive/html/bug-inetutils/2022-02/msg00014.html>
	bug reported by Erik Auerswald.

	Fix mem leak.  Reported by AiDai <wyxaidai@gmail.com>.
	* ifconfig/options.c (parse_cmdline): Call if_freenameindex.

	Sync bootstrap with gnulib.
	* bootstrap: Update.

	Use gnulib git submodule.

2022-01-01  Alfred M. Szmidt  <ams@gnu.org>

	Sync bootstrap with gnulib.
	    * bootstrap: Update.

	Happy GNU 2022 year!

2021-09-03  Simon Josefsson  <simon@josefsson.org>

	maint: Improve syntax-checks.
	* cfg.mk (local-checks-to-skip): Enable sc_immutable_NEWS.  Disable sc_indent.

	doc: Improve README-release.
	* gl/top/README-release.diff: Update.

	maint: Use copyright year ranges for readability.
	* cfg.mk (update-copyright-env): Add, from coreutils.
	(VC_LIST_ALWAYS_EXCLUDE_REGEX): Add, for update-copyright exceptions.
	* README: Add info about copyright year ranges.
	* *: Update copyright notices.

	doc: Fix typos, inspired by tiny BSD patches.

	doc: Update TODO.

	maint: Autoupdate for autoconf 2.71.
	* configure.ac: Don't use AC_TRY_LINK or AC_TRY_COMPILE.
	* am/libcurses.m4: Ditto.
	* am/krb5.m4: Ditto.

	doc: Mention maintenance fixes.
	* NEWS: Add.

2021-09-03  Simon Josefsson  <simon@josefsson.org>

	telnet: Don't infloop for malicious server.
	See https://bugs.debian.org/945861 and the tiny patch used by NetBSD:
	https://github.com/NetBSD/src/commit/36b8cfb2e28f691beae12da0c207086e1df0c8c4#diff-38b7213f9c6c21245fbeb4fad9520a27239d712a6dd0fea20dd6b77203b5737c

	* NEWS: Mention fix.
	* telnet/utilities.c (ExitString): Don't call SetForExit().

2021-09-02  Simon Josefsson  <simon@josefsson.org>

	maint: Include license text FDL as suggested by bootstrap.
	* doc/fdl-1.3.texi: New file, from gnulib.
	* bootstrap.conf (gnulib_modules): Remove fdl-1.3.

	doc: Use 'networkING utilities' consistently.
	* cfg.mk (manual_title): Fix.
	* doc/inetutils.texi (Introduction): Fix.

2021-09-01  Simon Josefsson  <simon@josefsson.org>

	Drop obsolete/unused AC_HEADER_DIRENT, AC_FUNC_CLOSEDIR_VOID and AC_FUNC_STRCOLL.
	* configure.ac: Remove calls.

	Drop unused IU_CHECK_WEAK_REFS.
	* configure.ac: Remove IU_CHECK_WEAK_REFS.
	* am/check_weak_refs.m4: Remove file.

	Don't use obsolete AC_TYPE_SIGNAL.
	* configure.ac: Remove call to AC_TYPE_SIGNAL.

	Use gnulib module 'attribute' instead of obsolete 'snippets/unused-parameters'.
	* */*.c: Use MAYBE_UNUSED instead of _GL_UNUSED_PARAMETER.
	* */*.c: Include attribute.h instead of unused-parameters.h.

	maint: Don't cc release announcement to translators.
	* maint.mk (translation_project_): Set to empty.

	maint: post-release administrivia
	* NEWS: Add header line for next release.
	* .prev-version: Record previous version.
	* cfg.mk (old_NEWS_hash): Auto-update.

	version 2.2
	* NEWS: Record release date.

	ftp: check that PASV/LSPV addresses match.
	* NEWS: Mention change.
	* ftp/ftp.c (initconn): Validate returned addresses.

2021-08-26  Simon Josefsson  <simon@josefsson.org>

	rlogind: Code for non-getaddrinfo removed.
	* NEWS: Mention change.
	* src/rlogind.c [!HAVE_DECL_GETADDRINFO]: Remove.

2021-07-26  Simon Josefsson  <simon@josefsson.org>

	logger: Code for non-getaddrinfo removed.
	* NEWS: Mention change.
	* src/logger.c [!HAVE_DECL_GETADDRINFO]: Remove.

	doc: Document recent fixes.
	* NEWS: Add.

2021-07-25  Simon Josefsson  <simon@josefsson.org>

	tests: Don't fail ftp-localhost.sh when sysctl is missing.
	* tests/ftp-localhost.sh: Silent fail.

2021-07-24  Simon Josefsson  <simon@josefsson.org>

	Don't check for getopt_long, no longer used anywhere.
	* configure.ac: Remove check.

	Don't check for getpass, getusershell, and poll (gnulib modules already imported).
	* configure.ac: Remove checks.

	Don't check for memcmp, memcpy, memmove, memset and strdup (no gnulib module needed).
	* configure.ac: Remove checks.

	Drop AC_C_CONST (obsolete).
	* configure.ac: Remove it.

	Use gnulib module socklen.
	* bootstrap.conf (gnulib_modules): Add it.
	* configure.ac: Don't look for it.

	Use gnulib modules stdarg, stdlib and string.
	* bootstrap.conf (gnulib_modules): Add them.
	* configure.ac: Don't look for them.

	Use gnulib environ module.
	* bootstrap.conf (gnulib_modules): Add environ.
	* configure.ac: Don't look for environ.

	Use gnulib errno module.
	* bootstrap.conf (gnulib_modules): Add errno.
	* configure.ac: Don't look for errno.h.

	Use gnulib getpeername module.
	* bootstrap.conf (gnulib_modules): Add getpeername.
	* configure.ac: Don't look for getpeername.

	Refresh some release-related build rules.
	* cfg.mk: Update.

	maint: post-release administrivia
	* NEWS: Add header line for next release.
	* .prev-version: Record previous version.
	* cfg.mk (old_NEWS_hash): Auto-update.

	version 2.1
	* NEWS: Record release date.

	Really try to fix gnulib fts usage.
	* libls/ls.c (ls_main): Use FTS_NOCHDIR.

	Fix gnulib fts usage.
	* libls/cmp.c: Include fts_.h instead of fts.h.
	* libls/ls.c: Likewise.
	* libls/print.c: Likewise.
	* libls/util.c: Likewise.

	Use gnulib's fts code instead of custom libls/ version.
	* bootstrap.conf (gnulib_modules): Add fts.
	* libls/fts.h, libls/fts.c: Remove files.
	* NEWS: Mention change.
	* configure.ac: Drop fchdir test.

	Remove tests obsoleted by gnulib.
	* configure.ac (poll.h, HAVE_SNPRINTF, HAVE_VSNPRINTF, strerror): Drop tests.

	Drop old or unnecessary build rules.
	* Makefile.am (DISTCLEANFILES): Remove inetutils*.tar*.
	(snapshot): Remove rule.
	* bootstrap.conf (bootstrap_sync): Remove, causes unnecessary *-dirty
	version number if bootstrap changes in gnulib.
	(.bootstrap): Remove custom code.
	* configure.ac: Remove no-op comments about old systems.

	doc: Improve README-release.
	* bootstrap.conf (bootstrap_epilogue): Remove.
	* gl/top/README-release.diff: Update.

	Depend on .version instead of configure.ac (for version number changes).
	man/Makefile.am: Fix *.1 dependencies.

	Reorganize NEWS entries.
	* NEWS: Update.

2021-07-20  Simon Josefsson  <simon@josefsson.org>

	doc: Remove completed TODO item.

2021-05-26  Simon Josefsson  <simon@josefsson.org>

	Sync bootstrap with gnulib.
	* bootstrap: Update.

	ftp: Fix usage under Emacs AngeFTP on Mac OS.
	* NEWS: Doc fix.
	* doc/inetutils.texi (ftp invocation): Improve --no-edit.
	* ftp/main.c (main): Disable readline when TERM unset or dumb,
	inspired by trivial patch from Alex Bochannek <alex@bochannek.com>.

2021-05-25  Simon Josefsson  <simon@josefsson.org>

	Mention 'whois' fixes.
	* NEWS: Add.

	Use gitlog-to-changelog.
	* bootstrap.conf (gnulib_modules): Add gitlog-to-changelog.
	(bootstrap_post_import_hook): Create ChangeLog, for automake.
	* Makefile.am (gen-ChangeLog): New rule.
	(dist-hook): Depend on gen-ChangeLog.
	(EXTRA_DIST): Distribute ChangeLog.1.
	* THANKS: Refer to version control logs too.
	* ChangeLog: Renamed to ChangeLog.1.
	* NEWS: Mention change.

2021-05-03  Alfred M. Szmidt  <ams@gnu.org>

	README: Update.

2021-04-28  Simon Josefsson  <simon@josefsson.org>

	telnet: Support --bind (-b) for NetKit compatibility.
	* NEWS: Add.
	* doc/inetutils.texi (telnet invocation): Add --bind (-b).
	* telnet/commands.c (tn): New variables hostaddr and srchostp.
	Parse -b parameter.  Update usage string.  If -b is set, call
	getaddrinfo on it and pass that ai_addr on to bind.
	* telnet/main.c (srcaddr): New global variable.
	(argp_options): Add --bind (-b).
	(parse_opt): Set srcaddr to -b value.
	(main): Propagate -b value to tn function.

2021-04-26  Ashish SHUKLA  <ashish.is@lostca.se>

	whois: Update whois server for .IN

	whois: .ORG is not handled by InterNIC anymore
	See https://www.iana.org/domains/root/db/org.html

2021-02-11  Simon Josefsson  <simon@josefsson.org>

	TODO: Add items discussed on mailing list.

2021-02-05  Simon Josefsson  <simon@josefsson.org>

	Use gnulib sys_types module so we can assume sys/types.h.
	* tests/waitdaemon.c, tests/runtime-ipv6.c, tests/readutmp.c: Drop
	HAVE_SYS_TYPES_H test.
	* bootstrap.conf (gnulib_modules): Add explicit sys_types.

	Fix some autoreconf 2.71 warnings.
	configure.ac: Remove obsolete AC_HEADER_STDC, AC_HEADER_TIME,
	AC_FUNC_SETVBUF_REVERSED, and AC_DECL_SYS_SIGLIST.  Don't check
	for sys/time.h, we never use the test result.

	Fix last commit.

	maint: post-release administrivia
	* NEWS: Add header line for next release.
	* .prev-version: Record previous version.
	* cfg.mk (old_NEWS_hash): Auto-update.

	version 2.0
	* NEWS: Record release date.
